Skip to content

feat(app): enable click action for gauge widgets - #373

Merged
alfredo1996 merged 1 commit into
release/1.1from
feat/issue-152-gauge-click-action
Apr 5, 2026
Merged

feat(app): enable click action for gauge widgets#373
alfredo1996 merged 1 commit into
release/1.1from
feat/issue-152-gauge-click-action

Conversation

@alfredo1996

@alfredo1996 alfredo1996 commented Apr 5, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary

  • Extends the existing click-action system to include gauge widgets (scope limited to gauge per user request — single-value is explicitly excluded).
  • Sets supportsClickAction: true in the gauge entry of chart-registry.ts.
  • Wires onClick={handleEChartsClick} through chart-renderer.tsx so the gauge's BaseChart receives ECharts click events.
  • Updates the chart-registry unit test to reflect the new behavior.

Closes #152

Test plan

  • app/src/lib/__tests__/chart-registry.test.ts updated — 271 tests pass
  • Manual: configure a click action on a gauge widget, click the gauge, confirm the single value row is dispatched as expected

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Summary by CodeRabbit

  • New Features
    • Gauge charts now support click interactions, allowing users to interact with and trigger actions from gauge visualizations.

@coderabbitai

coderabbitai Bot commented Apr 5, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 49c6ff51-c5ef-4a08-bf63-5fe34b881bc3

📥 Commits

Reviewing files that changed from the base of the PR and between f5246e3 and 3c11a79.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • app/src/components/chart-renderer.tsx
  • app/src/lib/__tests__/chart-registry.test.ts
  • app/src/lib/chart-registry.ts

Walkthrough

These changes enable click action support for gauge charts by updating the chart registry configuration to mark gauge as supporting click actions, wiring the click handler in the chart renderer component, and updating the corresponding test expectations.

Changes

Cohort / File(s) Summary
Gauge click support implementation
app/src/lib/chart-registry.ts, app/src/components/chart-renderer.tsx		 Updated gauge chart registry entry to set supportsClickAction: true and wired the ECharts onClick handler to existing handleEChartsClick callback.
Test updates
app/src/lib/__tests__/chart-registry.test.ts		 Updated chartSupportsClickAction test assertion for gauge chart type from false to true.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR implements gauge click handler and chart-registry configuration [#152], but single-value click handler and chart-settings-panel configurability remain incomplete. Complete implementation of single-value click handler and chart-settings-panel Advanced tab configurability to fully address issue #152 objectives.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: enabling click action support for gauge widgets.
Out of Scope Changes check ✅ Passed All changes directly support enabling click actions for gauge widgets; no unrelated modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/issue-152-gauge-click-action

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented Apr 5, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@alfredo1996
alfredo1996 merged commit 098f95e into release/1.1 Apr 5, 2026
12 of 13 checks passed
@alfredo1996
alfredo1996 deleted the feat/issue-152-gauge-click-action branch April 7, 2026 11:46
alfredo1996 added a commit that referenced this pull request May 10, 2026
@alfredo1996
Merge pull request #373 from alfredo1996/feat/issue-152-gauge-click-a…
40d0a7e 
…ction

feat(app): enable click action for gauge widgets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alfredo1996 @alfredorubin96